Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: check bind for development versions #6187

Merged
merged 3 commits into from
Jun 10, 2019
Merged

audit: check bind for development versions #6187

merged 3 commits into from
Jun 10, 2019

Conversation

javian
Copy link
Contributor

@javian javian commented May 30, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Add an audit that would have prevented Homebrew/homebrew-core#40343
Not sure if there's a guideline about where to place the audit in the file.

@MikeMcQuaid
Copy link
Member

Not sure if there's a guideline about where to place the audit in the file.

Somewhere around the existing ones at https://github.com/Homebrew/brew/blob/a5a18faae757945b441ac1216bef58fb8d9a5db0/Library/Homebrew/dev-cmd/audit.rb#L735 would be preferable. Thanks!

@MikeMcQuaid
Copy link
Member

@javian Sorry, to be more specific: can you add a check that matches those ones e.g. a new when in audit_specs, thanks.

@javian
Copy link
Contributor Author

javian commented Jun 9, 2019

I changed it up now and placed it where you asked.

@MikeMcQuaid MikeMcQuaid merged commit 1bee0fb into Homebrew:master Jun 10, 2019
@MikeMcQuaid
Copy link
Member

Made a few tweaks. Thanks @javian!

@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reitermarkus reitermarkus reitermarkus left review comments

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@javian @MikeMcQuaid @reitermarkus